Change in libosmo-sccp[master]: build: move include/{mtp, sccp} to include/osmocom/

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11120 )

Change subject: build: move include/{mtp,sccp} to include/osmocom/
......................................................................


Patch Set 3:

my apologies then, I though that moving it in the source tree would mean that it also gets installed into a different directory.

However, I still think it's wrong to move those directories.  the mtp and sccp headers are used differently than other osmocom libraries.  libmtp and libsccp don't have "osmo" in their naming.  Moving them would actually make them appear as standard libosmo*, which in reality they aren't.

To me, the proper clean up would rather be to not use any of the sccp headers in libosmo-sigtran.  I thought there even was a ticket related to that at some point.


-- 
To view, visit https://gerrit.osmocom.org/11120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1209a4ecf9f692a8030b5c93cd281fc9dd58d105
Gerrit-Change-Number: 11120
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Sep 2018 14:08:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/d37e3762/attachment.htm>