This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgHolger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/10686 ) Change subject: Create a "ms_driver" stub for the testsuite ...................................................................... Patch Set 2: (6 comments) I prefer not to spend the next weeks in trying to test/make the other event loop work for starting 20k processes in time but focus on getting to run a simple test running on Jenkins. https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py File src/osmo_gsm_tester/ms_driver.py: https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@68 PS1, Line 68: def prepare(self): > We usually used "configure()" for most object for this kind of action. Done https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@73 PS1, Line 73: # TODO: That needs some re-factoring > This temporary socket files needs to go into the run dir. […] I think I followed the pattern. I am not sure how self._run_dir get's passed into it? What do you think of a mix-in to: * Create the directory (use the dir= option for the tempfile.mkdtem call) * Use shutil.rmtree to recursively delete its contents? https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@81 PS1, Line 81: self._suite_run.remember_to_stop(self) > That's actually aimed at (sub)classes of process.py:Process. […] Done https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@97 PS1, Line 97: def run_test(self): > We usually used "start()" for most object for this kind of action. […] As you point out this method behaves differently to the rest of the test and I think for the next few weeks/months we have to cope with it. The mass test is fundamentally different to running with a handful of subscribers. and python and the current architecture/code didn't scale well (at least on my laptop and I didn't retest since then). The immediate goal is: * Start BTS/NITB, configure subs to be used by mass test. The long-term goal is: * Be able to use the "ms_driver" as a drop-in replacement for a modem. At this point I don't think switching an event loop helps us to gain any immediate benefit and I would prefer not to do it. Let's get a mass test going first and then iterate on it. What do you think of finding a more compatible name? start_and_wait? start_blocking? https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@113 PS1, Line 113: def terminate(self): > This should then be "cleanup(self)". Done https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/suite.py@311 PS1, Line 311: ip_address = self.ip_address() > You want to call self.register_for_cleanup(ms_driver) here. Done -- To view, visit https://gerrit.osmocom.org/10686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I586b6d532c6e6395b4e6f2cf2128372237d05a7d Gerrit-Change-Number: 10686 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Sun, 23 Sep 2018 17:25:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180923/0e4ec003/attachment.htm>