Change in osmo-sgsn[master]: gprs_sgsn.h: fix wrong type of re-attempts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Wed Sep 19 09:53:36 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11021 )

Change subject: gprs_sgsn.h: fix wrong type of re-attempts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11021/1/include/osmocom/sgsn/gprs_sgsn.h
File include/osmocom/sgsn/gprs_sgsn.h:

https://gerrit.osmocom.org/#/c/11021/1/include/osmocom/sgsn/gprs_sgsn.h@179
PS1, Line 179: 		int auth_reattempt; /* tracking UMTS resync auth attempts */
> yes, but it will hold only values from 0 - 2.
Then the range is that of an unsigned, and imho it's clearer just by looking at this line that no negative values are going to be used, no need to go check the code if some special values like -1 are being used.



-- 
To view, visit https://gerrit.osmocom.org/11021
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I708226cec9e131dcda4234f42ed3689f4f6750e8
Gerrit-Change-Number: 11021
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 19 Sep 2018 09:53:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180919/459569ac/attachment.htm>


More information about the gerrit-log mailing list