This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11007 ) Change subject: common/rsl.c: tweak log message in lapdm_rll_tx_cb() ...................................................................... common/rsl.c: tweak log message in lapdm_rll_tx_cb() During the investigation of OS#3559, it was discovered that the log message, which warns that an RSL message was dropped due to inactive logical channel, has incorrect log level - LOGL_INFO. This is not informative kind of message, so let's increase the log level, and additionally let's print the hexdump of message and it's length. Change-Id: I26eac5e4466c493ffe08dbb89de20f5e1c2bb85d --- M src/common/rsl.c 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/common/rsl.c b/src/common/rsl.c index 2aa7f4d..601b1c1 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2671,8 +2671,9 @@ rh = msgb_l2(msg); if (lchan->state != LCHAN_S_ACTIVE) { - LOGP(DRSL, LOGL_INFO, "%s(%s) is not active . Dropping message.\n", - gsm_lchan_name(lchan), gsm_lchans_name(lchan->state)); + LOGP(DRSL, LOGL_ERROR, "%s(%s) is not active. Dropping message (len=%u): %s\n", + gsm_lchan_name(lchan), gsm_lchans_name(lchan->state), + msgb_l2len(msg), msgb_hexdump_l2(msg)); msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/11007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I26eac5e4466c493ffe08dbb89de20f5e1c2bb85d Gerrit-Change-Number: 11007 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180919/e21affd2/attachment.htm>