This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10847 ) Change subject: CBCH: Add FIXME comments on queue overflow/underflow handling ...................................................................... CBCH: Add FIXME comments on queue overflow/underflow handling Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40 --- M src/common/cbch.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/common/cbch.c b/src/common/cbch.c index 56d76f1..7bbe2c9 100644 --- a/src/common/cbch.c +++ b/src/common/cbch.c @@ -136,6 +136,7 @@ } llist_add_tail(&scm->list, &bts->smscb_state.queue); + /* FIXME: limit queue size and optionally send CBCH LOAD Information (overflow) via RSL */ return 0; } @@ -145,8 +146,10 @@ struct smscb_msg *msg; msg = llist_first_entry_or_null(&bts->smscb_state.queue, struct smscb_msg, list); - if (!msg) + if (!msg) { + /* FIXME: send CBCH LOAD Information (underflow) via RSL */ return NULL; + } llist_del(&msg->list); -- To view, visit https://gerrit.osmocom.org/10847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ida97f25ab4bf7e4d0f03b13396cb37cdfe99ef40 Gerrit-Change-Number: 10847 Gerrit-PatchSet: 4 Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180917/f8abbdbd/attachment.htm>