Change in openbsc[master]: nat: return -EBADF in read wqueue cb on fd closed

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Sep 15 09:23:39 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10937 )

Change subject: nat: return -EBADF in read wqueue cb on fd closed
......................................................................

nat: return -EBADF in read wqueue cb on fd closed

bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd
bsc_msc_lost will close the current fd (without freeing it), so let's
skip possible writes to an already closed fd..

Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 8cc0f2d..c8a9e74 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -864,7 +864,7 @@
 				msc_con->name, ret);
 
 		bsc_msc_lost(msc_con);
-		return -1;
+		return -EBADF;
 	}
 
 	LOGP(DNAT, LOGL_DEBUG,

-- 
To view, visit https://gerrit.osmocom.org/10937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I55c1a88f6524e897c70abf8ba18f1bb2b1f650aa
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180915/a2fd4550/attachment.htm>


More information about the gerrit-log mailing list