Change in openbsc[master]: nat: Remove misleading comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Sep 15 09:23:37 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10935 )

Change subject: nat: Remove misleading comment
......................................................................

nat: Remove misleading comment

Code is already doing stuff with the connection (fd).

Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
---
M openbsc/src/osmo-bsc_nat/bsc_nat.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 0c91d04..0e69528 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1423,12 +1423,8 @@
 	if (rc != 0)
 		LOGP(DNAT, LOGL_ERROR, "Failed to set IP_TOS: %s\n", strerror(errno));
 
-	/* todo... do something with the connection */
 	/* todo... use GNUtls to see if we want to trust this as a BTS */
 
-	/*
-	 *
-	 */
 	bsc = bsc_connection_alloc(nat);
 	if (!bsc) {
 		LOGP(DNAT, LOGL_ERROR, "Failed to allocate BSC struct.\n");

-- 
To view, visit https://gerrit.osmocom.org/10935
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeaa0e024b9542d1a22a8e3ab4c3229a6f8a0b49
Gerrit-Change-Number: 10935
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180915/dd49a5fe/attachment.htm>


More information about the gerrit-log mailing list