This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Piotr Krysik gerrit-no-reply at lists.osmocom.orgPiotr Krysik has submitted this change and it was merged. ( https://gerrit.osmocom.org/10831 ) Change subject: apps/grgsm_trx: fix inaccurate sample rate calculation ...................................................................... apps/grgsm_trx: fix inaccurate sample rate calculation Change-Id: I0c309588fa0f7822abfb3919327639735db07679 --- M apps/grgsm_trx M python/trx/radio_if.py 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, but someone else must approve Piotr Krysik: Looks good to me, approved; Verified diff --git a/apps/grgsm_trx b/apps/grgsm_trx index 45312e6..6efed07 100755 --- a/apps/grgsm_trx +++ b/apps/grgsm_trx @@ -46,7 +46,7 @@ base_port = 6700 # PHY specific - phy_sample_rate = 4 * 1625000 / 6 + phy_sample_rate = radio_if.SAMPLE_RATE phy_freq_offset_hz = None phy_tx_antenna = "TX/RX" phy_rx_antenna = "RX2" diff --git a/python/trx/radio_if.py b/python/trx/radio_if.py index 407e724..2aeb49a 100644 --- a/python/trx/radio_if.py +++ b/python/trx/radio_if.py @@ -75,6 +75,9 @@ GSM_TS_PERIOD_uS = GSM_SYM_PERIOD_uS * 156.25 GSM_UL_DL_SHIFT_uS = -(GSM_TS_PERIOD_uS * 3) + # TODO: explain where do these values come from? + SAMPLE_RATE = 4.0 * 1625000.0 / 6.0 + # FIXME: shall be measured (automatically?) for # particular device and particular clock rate. # The current value is measured for USRP B2X0 at 26e6. -- To view, visit https://gerrit.osmocom.org/10831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0c309588fa0f7822abfb3919327639735db07679 Gerrit-Change-Number: 10831 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180913/f387c7f8/attachment.htm>