This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/10726 ) Change subject: BTS_Tests: check paging channel fn (bs_ag_blks_res) ...................................................................... Patch Set 2: > It's a bit of a philosophy question. I typically try to not test > too many things in one patch. For example, if the patch is about > testing paging load reporting, then that test should only test > whatever is required in that context, and not verify if paging > blocks are send on AGCH, as that's "out of scope". It's sometimes > difficult to draw the line, and this is not a strict rule. I'm > just explaining my rationale why I didn't add such checks before. > > But we can merge this one. Just in the future, keep it in mind > that it's typically better to have more specific test cases rather > than single test cases that test tons of thing in one. Thanks for the hint. I will keep this in mind for next time. -- To view, visit https://gerrit.osmocom.org/10726 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I839e75ece05166518bf7132acd3017434b3d3bc2 Gerrit-Change-Number: 10726 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Comment-Date: Wed, 12 Sep 2018 15:59:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180912/6786574b/attachment.htm>