Change in libosmocore[master]: logging: define lower-case loglevel value_string[]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Sep 12 13:58:50 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10886 )

Change subject: logging: define lower-case loglevel value_string[]
......................................................................


Patch Set 1:

I don't really like that approach.  The number of times when we "constantly" conver the strings is actually very low.  I don't see any need for optimization at all. This doesn't seem to be something we do many times per second, or maybe even during logging of each log line - but only at the time somebody enters a VTY command that gets parsed.

So I'd prefer to have that miniscule runtime overhead at rare occasions, than to have copy+paste of the table


-- 
To view, visit https://gerrit.osmocom.org/10886
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie55d732281bdf74324e1dd7f8a2ba91d11409851
Gerrit-Change-Number: 10886
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 12 Sep 2018 13:58:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180912/2f77b076/attachment.htm>


More information about the gerrit-log mailing list