Change in gr-gsm[master]: burst_file_source: Fix reading longer bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vasil Velichkov gerrit-no-reply at lists.osmocom.org
Wed Sep 12 11:08:51 UTC 2018


Vasil Velichkov has posted comments on this change. ( https://gerrit.osmocom.org/10881 )

Change subject: burst_file_source: Fix reading longer bursts
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/10881/1/lib/misc_utils/burst_file_source_impl.cc
File lib/misc_utils/burst_file_source_impl.cc:

https://gerrit.osmocom.org/#/c/10881/1/lib/misc_utils/burst_file_source_impl.cc@96
PS1, Line 96:         d_input_file.close();
> ws
Done


https://gerrit.osmocom.org/#/c/10881/1/python/qa_burst_file_source.py
File python/qa_burst_file_source.py:

https://gerrit.osmocom.org/#/c/10881/1/python/qa_burst_file_source.py@1
PS1, Line 1: #!/usr/bin/env python
> Would this script work with both Python 2 and 3? […]
It should once the gnuradio supports python3.
I prefer not to change this as all other python tests are like this and gr_modtool also generate new tests with python and not python2/3



-- 
To view, visit https://gerrit.osmocom.org/10881
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I989b0d6a6b214088b7880e5cbf7bb6725492dbfc
Gerrit-Change-Number: 10881
Gerrit-PatchSet: 2
Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Wed, 12 Sep 2018 11:08:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180912/4a4c1f8e/attachment.htm>


More information about the gerrit-log mailing list