Change in osmo-bts[master]: log: add error log for RSL Chan Mode Modif

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Sep 10 22:30:13 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10869


Change subject: log: add error log for RSL Chan Mode Modif
......................................................................

log: add error log for RSL Chan Mode Modif

Add log context to chan_mode error in rsl_rx_mode_modif().

Tweaked-by: neels
Change-Id: I945cf1ca8660ad5daf097edab1833bbc74b6185f
---
M src/common/rsl.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/69/10869/1

diff --git a/src/common/rsl.c b/src/common/rsl.c
index ad2d4de..2aa7f4d 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -1499,7 +1499,10 @@
 	lchan_tchmode_from_cmode(lchan, cm);
 
 	if (bts_supports_cm(lchan->ts->trx->bts, ts_pchan(lchan->ts), lchan->tch_mode) != 1) {
-		LOGP(DRSL, LOGL_ERROR, "invalid mode/codec instructed by BSC, check BSC configuration.\n");
+		LOGP(DRSL, LOGL_ERROR,
+		     "%s %s: invalid mode: %s (wrong BSC configuration?)\n",
+		     gsm_ts_and_pchan_name(lchan->ts), gsm_lchan_name(lchan),
+		     gsm48_chan_mode_name(lchan->tch_mode));
 		return rsl_tx_mode_modif_nack(lchan, RSL_ERR_SERV_OPT_UNAVAIL);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/10869
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I945cf1ca8660ad5daf097edab1833bbc74b6185f
Gerrit-Change-Number: 10869
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180910/bd7c662a/attachment.htm>


More information about the gerrit-log mailing list