Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Sep 9 15:37:44 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10850 )

Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH channel
......................................................................

cbch: Don't send cell-broadcast command on BTS without CBCH channel

Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index e99029a..b1938e6 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -4240,6 +4240,10 @@
 		vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE);
 		return CMD_WARNING;
 	}
+	if (!gsm_bts_get_cbch(bts)) {
+		vty_out(vty, "%% BTS %d doesn't have a CBCH%s", bts_nr, VTY_NEWLINE);
+		return CMD_WARNING;
+	}
 	rc = osmo_hexparse(argv[2], buf, sizeof(buf));
 	if (rc < 0 || rc > sizeof(buf)) {
 		vty_out(vty, "Error parsing HEXSTRING%s", VTY_NEWLINE);

-- 
To view, visit https://gerrit.osmocom.org/10850
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92
Gerrit-Change-Number: 10850
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180909/2f02121b/attachment.htm>


More information about the gerrit-log mailing list