Change in osmo-bsc[master]: ho fsm: handle RR HO Failure for inter-BSC outgoing

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Sep 7 14:34:59 UTC 2018


Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/10834


Change subject: ho fsm: handle RR HO Failure for inter-BSC outgoing
......................................................................

ho fsm: handle RR HO Failure for inter-BSC outgoing

Before, this would ignore the failure and hit a timeout instead. Rather handle
the event directly.

Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 16 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/10834/1

diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index a42f10c..9d558bc 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -1025,6 +1025,18 @@
 	}
 }
 
+static void ho_out_fsm_wait_clear(struct osmo_fsm_inst *fi, uint32_t event, void *data)
+{
+	struct gsm_subscriber_connection *conn = ho_fi_conn(fi);
+	switch (event) {
+	case HO_EV_RR_HO_FAIL:
+		ho_fail(HO_RESULT_FAIL_RR_HO_FAIL, "Received RR Handover Failure message");
+		return;
+
+	default:
+		OSMO_ASSERT(false);
+	}
+}
 
 #define S(x)	(1 << (x))
 
@@ -1108,6 +1120,10 @@
 	},
 	[HO_OUT_ST_WAIT_CLEAR] = {
 		.name = "inter-BSC-OUT:WAIT_CLEAR",
+		.in_event_mask = 0
+			| S(HO_EV_RR_HO_FAIL)
+			,
+		.action = ho_out_fsm_wait_clear,
 	},
 };
 

-- 
To view, visit https://gerrit.osmocom.org/10834
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I21c43d2907d0413ef18ec43cf27f680ebecf9e82
Gerrit-Change-Number: 10834
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180907/e07641e6/attachment.htm>


More information about the gerrit-log mailing list