Change in osmocom-bb[master]: trxcon: distinguish between unimplemented and unknown messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Sep 6 21:54:27 UTC 2018


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/10432 )

Change subject: trxcon: distinguish between unimplemented and unknown messages
......................................................................

trxcon: distinguish between unimplemented and unknown messages

Let's differentiate between 'expected' unimplemented messages
like L1CTL_NEIGH_PM_REQ and truly unknonw message types.

Change-Id: Id76993056fb514e6fb0242d505205316c61bb965
---
M src/host/trxcon/l1ctl.c
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c
index b0a4c6d..230ef0a 100644
--- a/src/host/trxcon/l1ctl.c
+++ b/src/host/trxcon/l1ctl.c
@@ -792,6 +792,16 @@
 		return l1ctl_rx_tch_mode_req(l1l, msg);
 	case L1CTL_CRYPTO_REQ:
 		return l1ctl_rx_crypto_req(l1l, msg);
+
+	/* Not (yet) handled messages */
+	case L1CTL_NEIGH_PM_REQ:
+	case L1CTL_DATA_TBF_REQ:
+	case L1CTL_TBF_CFG_REQ:
+	case L1CTL_DM_FREQ_REQ:
+	case L1CTL_SIM_REQ:
+		LOGP(DL1C, LOGL_NOTICE, "Ignoring unsupported message "
+			"(type=%u)\n", l1h->msg_type);
+		return -ENOTSUP;
 	default:
 		LOGP(DL1C, LOGL_ERROR, "Unknown MSG type %u: %s\n", l1h->msg_type,
 			osmo_hexdump(msgb_data(msg), msgb_length(msg)));

-- 
To view, visit https://gerrit.osmocom.org/10432
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id76993056fb514e6fb0242d505205316c61bb965
Gerrit-Change-Number: 10432
Gerrit-PatchSet: 4
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/2bc2f1b0/attachment.htm>


More information about the gerrit-log mailing list