Change in osmocom-bb[master]: trxcon/trx_if.c: use proper format specifiers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Sep 6 09:33:03 UTC 2018


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/10779 )

Change subject: trxcon/trx_if.c: use proper format specifiers
......................................................................

trxcon/trx_if.c: use proper format specifiers

The '%u' format specifier should be used for unsigned values.

Change-Id: I90200581036f8ab3969dd68664688f98cd2d3618
---
M src/host/trxcon/trx_if.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index e08857c..89331f3 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -295,7 +295,7 @@
 
 int trx_if_cmd_setslot(struct trx_instance *trx, uint8_t tn, uint8_t type)
 {
-	return trx_ctrl_cmd(trx, 1, "SETSLOT", "%d %d", tn, type);
+	return trx_ctrl_cmd(trx, 1, "SETSLOT", "%u %u", tn, type);
 }
 
 /*
@@ -321,7 +321,7 @@
 		return -ENOTSUP;
 	}
 
-	return trx_ctrl_cmd(trx, 1, "RXTUNE", "%d", freq10 * 100);
+	return trx_ctrl_cmd(trx, 1, "RXTUNE", "%u", freq10 * 100);
 }
 
 int trx_if_cmd_txtune(struct trx_instance *trx, uint16_t band_arfcn)
@@ -335,7 +335,7 @@
 		return -ENOTSUP;
 	}
 
-	return trx_ctrl_cmd(trx, 1, "TXTUNE", "%d", freq10 * 100);
+	return trx_ctrl_cmd(trx, 1, "TXTUNE", "%u", freq10 * 100);
 }
 
 /*
@@ -366,7 +366,7 @@
 		return -ENOTSUP;
 	}
 
-	return trx_ctrl_cmd(trx, 1, "MEASURE", "%d", freq10 * 100);
+	return trx_ctrl_cmd(trx, 1, "MEASURE", "%u", freq10 * 100);
 }
 
 static void trx_if_measure_rsp_cb(struct trx_instance *trx, char *resp)

-- 
To view, visit https://gerrit.osmocom.org/10779
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I90200581036f8ab3969dd68664688f98cd2d3618
Gerrit-Change-Number: 10779
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/01292b13/attachment.htm>


More information about the gerrit-log mailing list