Change in osmo-trx[master]: radioInterface: Fix variable storing integer return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Sep 4 17:35:50 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10744 )

Change subject: radioInterface: Fix variable storing integer return value
......................................................................

radioInterface: Fix variable storing integer return value

Change-Id: I0a0a06a6d16a228cfcb7bd746bab2d79f10ce244
---
M Transceiver52M/radioInterface.cpp
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/Transceiver52M/radioInterface.cpp b/Transceiver52M/radioInterface.cpp
index b9c6672..7d6a03b 100644
--- a/Transceiver52M/radioInterface.cpp
+++ b/Transceiver52M/radioInterface.cpp
@@ -304,7 +304,8 @@
 int RadioInterface::pullBuffer()
 {
   bool local_underrun;
-  size_t numRecv, segmentLen = recvBuffer[0]->getSegmentLen();
+  int numRecv;
+  size_t segmentLen = recvBuffer[0]->getSegmentLen();
 
   if (recvBuffer[0]->getFreeSegments() <= 0)
     return -1;
@@ -316,7 +317,7 @@
                                 readTimestamp,
                                 &local_underrun);
 
-  if (numRecv != segmentLen) {
+  if ((size_t) numRecv != segmentLen) {
           LOG(ALERT) << "Receive error " << numRecv;
           return -1;
   }

-- 
To view, visit https://gerrit.osmocom.org/10744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a0a06a6d16a228cfcb7bd746bab2d79f10ce244
Gerrit-Change-Number: 10744
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180904/f994c364/attachment.htm>


More information about the gerrit-log mailing list