Change in osmo-trx[master]: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly o...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Mon Sep 3 17:15:33 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10743 )

Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/10743/2/CommonLibs/osmo_signal.h
File CommonLibs/osmo_signal.h:

https://gerrit.osmocom.org/#/c/10743/2/CommonLibs/osmo_signal.h@21
PS2, Line 21: /* Generic signalling/notification infrastructure */
Makes sense to move this line to the top, just before the
copyright statement as we do in other files.


https://gerrit.osmocom.org/#/c/10743/2/CommonLibs/osmo_signal.h@28
PS2, Line 28:  * Signalling subsystems
cosmetic: this is a single line comment



-- 
To view, visit https://gerrit.osmocom.org/10743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac1d2dbe2328e735db2d4b933cb67b1af1babca1
Gerrit-Change-Number: 10743
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 03 Sep 2018 17:15:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180903/20ee775d/attachment.htm>


More information about the gerrit-log mailing list