This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10743 ) Change subject: osmo-trx: Add osmo_signal to stop whole transceiver chain correctly on error ...................................................................... Patch Set 1: Code-Review+1 (1 comment) fine except for cosmetics https://gerrit.osmocom.org/#/c/10743/1/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/10743/1/Transceiver52M/Transceiver.cpp@228 PS1, Line 228: if(this->sig_cbfn) where does this coding style come from? if is not a function ,and even existing code in this file doesn't seem to use this style? SCNR. -- To view, visit https://gerrit.osmocom.org/10743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac1d2dbe2328e735db2d4b933cb67b1af1babca1 Gerrit-Change-Number: 10743 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 03 Sep 2018 15:56:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180903/c4074492/attachment.htm>