Change in osmo-sip-connector[master]: mncc: Fix missing conditional clause

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10734 )

Change subject: mncc: Fix missing conditional clause
......................................................................

mncc: Fix missing conditional clause

Fixes following compilation warning:
osmo-sip-connector/src/mncc.c: In function ‘check_disc_ind’:
osmo-sip-connector/src/mncc.c:517:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
  if (other_leg)
  ^~

Fixes: 008915ee41900c34ec0fd8df0c9f1d7c2cbdb3b2 ("Implement Cause Mapping")

Change-Id: I5bdbc29a3f82bdc92b156c1f7df68c9503f85f8f
---
M src/mncc.c
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/mncc.c b/src/mncc.c
index f41bb51..ae60321 100644
--- a/src/mncc.c
+++ b/src/mncc.c
@@ -514,9 +514,10 @@
 	mncc_send(leg->conn, MNCC_REL_REQ, leg->callref);
 
 	other_leg = call_leg_other(&leg->base);
-	if (other_leg)
+	if (other_leg) {
 		other_leg->cause = data->cause.value;
 		other_leg->release_call(other_leg);
+	}
 }
 
 static void check_rel_ind(struct mncc_connection *conn, const char *buf, int rc)
@@ -533,9 +534,10 @@
 	else {
 		struct call_leg *other_leg;
 		other_leg = call_leg_other(&leg->base);
-		if (other_leg)
+		if (other_leg) {
 			other_leg->cause = data->cause.value;
 			other_leg->release_call(other_leg);
+		}
 	}
 	LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was released.\n", data->callref);
 	mncc_leg_release(leg);
@@ -581,9 +583,10 @@
 
 	leg->cause = data->cause.value;
 	other_leg = call_leg_other(&leg->base);
-	if (other_leg)
+	if (other_leg) {
 		other_leg->cause = data->cause.value;
 		other_leg->release_call(other_leg);
+	}
 	LOGP(DMNCC, LOGL_DEBUG, "leg(%u) was rejected.\n", data->callref);
 	mncc_leg_release(leg);
 }

-- 
To view, visit https://gerrit.osmocom.org/10734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdbc29a3f82bdc92b156c1f7df68c9503f85f8f
Gerrit-Change-Number: 10734
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180903/7bbaf844/attachment.htm>