This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10732 ) Change subject: Add CC_CAUSE value_string array ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10732/1/src/gsm/gsm48.c File src/gsm/gsm48.c: https://gerrit.osmocom.org/#/c/10732/1/src/gsm/gsm48.c@950 PS1, Line 950: OSMO_VALUE_STRING(GSM48_CC_CAUSE_UNASSIGNED_NR), > ?? This might be nicer to have as a shorter string array in the style of (for example) gsm48_pdisc_n […] very much so, yes. I was about to mkae that comment myself. I'm not a big fan of OSMO_VALUE_STRING for exactly that resason. -- To view, visit https://gerrit.osmocom.org/10732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I296f208581ce2550805f9d96e20f7319e1199023 Gerrit-Change-Number: 10732 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-Comment-Date: Sat, 01 Sep 2018 10:43:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180901/9400c849/attachment.htm>