Change in libosmo-sccp[master]: vty: SCCP timers: add optional units

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Oct 31 08:19:41 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11130 )

Change subject: vty: SCCP timers: add optional units
......................................................................


Patch Set 2: Code-Review-1

We don't need sub-second resolution timers here.  The way how timers/timeouts are treated in other parts of the code is that the unit is stated in the help text for the timer, so pressing "?" while entering will give you a hint in what kind of unit to enter it.

I think it's absolutely acceptable for timers that are in the few-seconds to few-minutes cases (like here for SCCP) to expect the user to be able to compute something like 180 seconds or 240 seconds in their head to 3 or 4 minutes.

So unless Neels has a really strong feeling about this, I would rather say no.  We generally should have one way of specifying a given parameter, not N number of different ways.  Particularly not, if this is for one given sub-system only, and not a generalized feature available to every piece of code using the VTY.  And having a generalized feature would require a much higher abstraction level of the VTY.


-- 
To view, visit https://gerrit.osmocom.org/11130
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I020d5dab19bc67e8444ed548db15b2a4d8871a9c
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Oct 2018 08:19:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181031/3e9a51a7/attachment.htm>


More information about the gerrit-log mailing list