This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11493 ) Change subject: vty: add 'show rejected-bts' ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/11493/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/11493/3/include/osmocom/bsc/gsm_data.h@1139 PS3, Line 1139: char ip[64]; You can use the ADDRLEN6LEN or however it's called here. https://gerrit.osmocom.org/#/c/11493/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/11493/3/src/osmo-bsc/bsc_vty.c@566 PS3, Line 566: vty_out(vty, "%s %7u %6u %15s%s", buf, pos->site_id, pos->bts_id, pos->ip, VTY_NEWLINE); why do we need this %15s for pos->ip? isn't %s enough? https://gerrit.osmocom.org/#/c/11493/3/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/#/c/11493/3/src/osmo-bsc/bts_ipaccess_nanobts.c@525 PS3, Line 525: ipaccess_sign_link_reject(dev, &line->ts[E1INP_SIGN_OML - 1]); So as a result afaiu we'll only print OML IP addreses here, even if we failed during an RSL conn attempt, but it's fine enough I guess. -- To view, visit https://gerrit.osmocom.org/11493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba3bfe8fc9432b7ae8f819df8bd71b35b3ec507e Gerrit-Change-Number: 11493 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 30 Oct 2018 13:34:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181030/5a761ce6/attachment.htm>