Change in libosmo-sccp[master]: vty: SCCP timers: add optional units

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Oct 30 12:54:12 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11130 )

Change subject: vty: SCCP timers: add optional units
......................................................................


Patch Set 2:

(1 comment)

I remember reading an argument against this patch regarding being different from how we handle timers in rest of osmocom code (like we always use seconds and that's all).

Do we really need less-than-a-second resolution?

https://gerrit.osmocom.org/#/c/11130/2/src/sccp_vty.c
File src/sccp_vty.c:

https://gerrit.osmocom.org/#/c/11130/2/src/sccp_vty.c@170
PS2, Line 170: 	
whitespace



-- 
To view, visit https://gerrit.osmocom.org/11130
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I020d5dab19bc67e8444ed548db15b2a4d8871a9c
Gerrit-Change-Number: 11130
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Oct 2018 12:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181030/f733e0bd/attachment.htm>


More information about the gerrit-log mailing list