Change in osmo-ttcn3-hacks[master]: bsc: Use f_gen_test_hdlr_pars() to be aware of AoIP/sccplite

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

daniel gerrit-no-reply at lists.osmocom.org
Mon Oct 29 15:54:53 UTC 2018


daniel has uploaded this change for review. ( https://gerrit.osmocom.org/11500


Change subject: bsc: Use f_gen_test_hdlr_pars() to be aware of AoIP/sccplite
......................................................................

bsc: Use f_gen_test_hdlr_pars() to be aware of AoIP/sccplite

Some TC_no_out_fail_* testcases still used valueof() to get g_pars which
always set aoip to true.

Use f_gen_test_hdlr_pars() now so these tests can properly detect if
they are run with sccplite of aoip and can adjust their expectations
accordingly.

Change-Id: Ic164827d63c9f5452888951bba4c197c3fe6f57b
---
M bsc/BSC_Tests.ttcn
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/11500/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index fef5fd7..ae855bd 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -2277,7 +2277,7 @@
 /* BSC asks for inter-BSC HO, but the MSC decides that it won't happen and
  * simply never sends a BSSMAP Handover Command. */
 private function f_tc_ho_out_fail_no_msc_response(charstring id) runs on MSC_ConnHdlr {
-	g_pars := valueof(t_def_TestHdlrPars);
+	g_pars := f_gen_test_hdlr_pars();
 
 	var PDU_BSSAP ass_req := f_gen_ass_req();
 	ass_req.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);
@@ -2323,7 +2323,7 @@
 /* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports
  * RR Handover Failure. */
 private function f_tc_ho_out_fail_rr_ho_failure(charstring id) runs on MSC_ConnHdlr {
-	g_pars := valueof(t_def_TestHdlrPars);
+	g_pars := f_gen_test_hdlr_pars();
 
 	var PDU_BSSAP ass_req := f_gen_ass_req();
 	ass_req.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);
@@ -2406,7 +2406,7 @@
 /* BSC asks for inter-BSC HO, receives BSSMAP Handover Command, but MS reports
  * RR Handover Failure. */
 private function f_tc_ho_out_fail_no_ho_detect(charstring id) runs on MSC_ConnHdlr {
-	g_pars := valueof(t_def_TestHdlrPars);
+	g_pars := f_gen_test_hdlr_pars();
 
 	var PDU_BSSAP ass_req := f_gen_ass_req();
 	ass_req.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType);

-- 
To view, visit https://gerrit.osmocom.org/11500
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic164827d63c9f5452888951bba4c197c3fe6f57b
Gerrit-Change-Number: 11500
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181029/56470a61/attachment.htm>


More information about the gerrit-log mailing list