Change in osmocom-bb[master]: l1ctl_proto.h: use flexible array member for traffic messages

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11395 )

Change subject: l1ctl_proto.h: use flexible array member for traffic messages
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11395/2/src/host/layer23/src/common/l1ctl.c
File src/host/layer23/src/common/l1ctl.c:

https://gerrit.osmocom.org/#/c/11395/2/src/host/layer23/src/common/l1ctl.c@781
PS2, Line 781: size_t frame_len;
             : 	uint8_t *frame;
I don't really see the point of introducing those two variables.  Why not simply use msgb->l3h = (uint8_t *)data;  and then use msgb_l3len(msg) where you want to access frame_len and mesb_l3(msg) when you want frame?



-- 
To view, visit https://gerrit.osmocom.org/11395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I119fa36c84e95c3003d57c19e25f8146ed45c3c6
Gerrit-Change-Number: 11395
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 28 Oct 2018 20:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181028/80a251bf/attachment.htm>