This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11455 ) Change subject: add osmo_sock_get_{local,remote}_ip{,_port}() ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11455/2/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/#/c/11455/2/include/osmocom/core/socket.h@60 PS2, Line 60: bool please don't make them return bool. We don't have any functions in osmocom that return bool, *except* for predicate functions that are used to check for some condition. The general semantics are, like many things, like in the linux kernel: 0 is success, negativ is error, and positive is used to e.g. indicate the size/number of bytes/... -- To view, visit https://gerrit.osmocom.org/11455 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6803c204771c59a2002bc6a0e6b79c83c35f87e1 Gerrit-Change-Number: 11455 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Fri, 26 Oct 2018 14:12:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181026/4b2dd607/attachment.htm>