Change in osmo-msc[master]: Fix VLR test macro

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Oct 25 18:00:38 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/6296 )

Change subject: Fix VLR test macro
......................................................................


Patch Set 7:

are the tests ever likely going to have more than one "conn" they want to match on?  If no, using a global varialbe is perfectly ok.  To me, this seems to be another "let's change something for the purpose of changing something" kind of commits.  You can find as many arguments against that change as you can find for it, I find it highly questionable to spend time on it, sorry.


-- 
To view, visit https://gerrit.osmocom.org/6296
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I36ae1f9bb395921dc2c5a39e35fbb8040ba47213
Gerrit-Change-Number: 6296
Gerrit-PatchSet: 7
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Oct 2018 18:00:38 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181025/d8844de9/attachment.htm>


More information about the gerrit-log mailing list