Change in osmocom-bb[master]: mobile: cleanup app init

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Oct 25 17:53:46 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11456 )

Change subject: mobile: cleanup app init
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11456/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11456/1//COMMIT_MSG@9
PS1, Line 9: remove redundant printf
ok, fine.


https://gerrit.osmocom.org/#/c/11456/1//COMMIT_MSG@10
PS1, Line 10: use boolean where appropriate
this is exactly the kind of "clean up" which I saw at times in the past and kept wondering:  Which particular task/ticket/work-item does this address?  Is that really worth our valuable and quite limited time and resources?


https://gerrit.osmocom.org/#/c/11456/1/src/host/layer23/src/mobile/main.c
File src/host/layer23/src/mobile/main.c:

https://gerrit.osmocom.org/#/c/11456/1/src/host/layer23/src/mobile/main.c@92
PS1, Line 92:        
replacing tabs with spaces?



-- 
To view, visit https://gerrit.osmocom.org/11456
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc38feb03656bd9a52aa29095ff7423e0e6ad53b
Gerrit-Change-Number: 11456
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 25 Oct 2018 17:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181025/9c6c52ff/attachment.htm>


More information about the gerrit-log mailing list