Change in libosmocore[master]: add osmo_sock_get_{local, remote}_ip{, _port}()

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11455 )

Change subject: add osmo_sock_get_{local,remote}_ip{,_port}()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/core/socket.h
File include/osmocom/core/socket.h:

https://gerrit.osmocom.org/#/c/11455/1/include/osmocom/core/socket.h@59
PS1, Line 59: char *osmo_sock_get_name2(void *ctx, int fd, bool local, bool port);
> If that's meant for internal use (as per comment in . […]
I thought that was necessary to use it with the defines below. How do we not make it public, add an underscore in front of the function?


https://gerrit.osmocom.org/#/c/11455/1/src/socket.c
File src/socket.c:

https://gerrit.osmocom.org/#/c/11455/1/src/socket.c@714
PS1, Line 714: 
> There seems to be some code duplication with osmo_sock_get_name() - any chance to unify that?
Good question. I'll try it out tomorrow by adding hostbuf and portbuf arguments to osmo_sock_get_name2, and if they are not NULL, write the results into them. Then it's possible to use osmo_sock_get_name2() from the function below and make it a bit less redundant.



-- 
To view, visit https://gerrit.osmocom.org/11455
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6803c204771c59a2002bc6a0e6b79c83c35f87e1
Gerrit-Change-Number: 11455
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Oct 2018 15:01:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181025/54405098/attachment.htm>