Change in osmo-ttcn3-hacks[master]: bts: Disable testing FACCH/H with real HW

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11428 )

Change subject: bts: Disable testing FACCH/H with real HW
......................................................................

bts: Disable testing FACCH/H with real HW

Temporary disable testing on FACCH/H because Calypso PHY is not stable.
Otherwise some tests fail half of the time due to this unstability.

Related: OS#3653
Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
---
M bts/BTS_Tests.ttcn
1 file changed, 22 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index a2d4ca4..fe0a933 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -313,17 +313,29 @@
 		valueof(ts_RslChanNr_SDCCH8(6,4)), valueof(ts_RslChanNr_SDCCH8(6,5)),
 		valueof(ts_RslChanNr_SDCCH8(6,6)), valueof(ts_RslChanNr_SDCCH8(6,7))
 	};
-	g_AllChanTypes := {
-		/* TS 1..4: TCH/F */
-		valueof(ts_RslChanNr_Bm(1)),
-		/* TS 5: TCH/H */
-		valueof(ts_RslChanNr_Lm(5,1)),
-		/* TS 0: SDCCH/4 */
-		valueof(ts_RslChanNr_SDCCH4(0,2)),
-		/* TS 6: SDCCH/8 */
-		valueof(ts_RslChanNr_SDCCH8(6,4))
-	};
 
+	/* FIXME: FACCH/H is unreliable with calypso firmware, see OS#3653 */
+	if (mp_bb_trxc_port != -1) {
+		g_AllChanTypes := {
+			/* TS 1..4: TCH/F */
+			valueof(ts_RslChanNr_Bm(1)),
+			/* TS 5: TCH/H */
+			valueof(ts_RslChanNr_Lm(5,1)),
+			/* TS 0: SDCCH/4 */
+			valueof(ts_RslChanNr_SDCCH4(0,2)),
+			/* TS 6: SDCCH/8 */
+			valueof(ts_RslChanNr_SDCCH8(6,4))
+		};
+	} else {
+		g_AllChanTypes := {
+			/* TS 1..4: TCH/F */
+			valueof(ts_RslChanNr_Bm(1)),
+			/* TS 0: SDCCH/4 */
+			valueof(ts_RslChanNr_SDCCH4(0,2)),
+			/* TS 6: SDCCH/8 */
+			valueof(ts_RslChanNr_SDCCH8(6,4))
+		};
+	}
 	f_init_rsl(id);
 	T.start;
 	alt {

-- 
To view, visit https://gerrit.osmocom.org/11428
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d
Gerrit-Change-Number: 11428
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181023/e1d48bb7/attachment.htm>