This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/11425 Change subject: gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN ...................................................................... gsm_pchan2chan_nr: Fix conversion of CCCH_LCHAN Previous implementation made no sense, since chan_nr is never read before being set below from lchan_nr. Furthemore, if lcahn_nr=CCH_LCHAN=4, then: cbits = 0x4 + lchan_nr = 0x8 = b1000 which then becomes SDCCH8 according to GSM 08.58 9.3.1, so it's totally wrong: SDCCH/8 + ACCH 0 1 T T T Change-Id: Id1dee716991e6faa406f02c029e998af5780162a --- M src/common/gsm_data_shared.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/11425/1 diff --git a/src/common/gsm_data_shared.c b/src/common/gsm_data_shared.c index 2a1f9c8..8c3229c 100644 --- a/src/common/gsm_data_shared.c +++ b/src/common/gsm_data_shared.c @@ -622,7 +622,7 @@ * See osmo-bts-xxx/oml.c:opstart_compl(). */ if (lchan_nr == CCCH_LCHAN) - chan_nr = 0; + lchan_nr = 0; else OSMO_ASSERT(lchan_nr < 4); cbits = 0x04; -- To view, visit https://gerrit.osmocom.org/11425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id1dee716991e6faa406f02c029e998af5780162a Gerrit-Change-Number: 11425 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181022/062f260a/attachment.htm>