This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: assert message type in osmo_gsup_encode() ...................................................................... Patch Set 1: It's debatable. -ENOMEM for sure is an odd return code for an invalid input value. but yes, since any caller needs to check for the return value anyway, the OSMO_ASSERT() solution isn't the best option either. Why not simply return -EINVAL? -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-CC: Harald Welte <laforge at gnumonks.org> Gerrit-Comment-Date: Sun, 21 Oct 2018 12:18:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181021/f7339aed/attachment.htm>