Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Oct 21 12:11:28 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11414 )

Change subject: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()
......................................................................

gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Fixes: Coverity CID#182702
---
M src/libmsc/gsm_04_08.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 0f52d09..d5cc212 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -1397,7 +1397,8 @@
 {
 	struct gsm48_hdr *gh;
 	uint8_t pdisc;
-	uint8_t n_sd, modulo, bin;
+	uint8_t n_sd, modulo;
+	int bin;
 
 	gh = msgb_l3(msg);
 	pdisc = gsm48_hdr_pdisc(gh);

-- 
To view, visit https://gerrit.osmocom.org/11414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If9525694bcbc5c6c0e622e899dd634dc11ed61c4
Gerrit-Change-Number: 11414
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181021/795a5ed7/attachment.htm>


More information about the gerrit-log mailing list