This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11375 ) Change subject: mgcp: Log endpoint nr consistently as hex ...................................................................... mgcp: Log endpoint nr consistently as hex Port from openbsc 078905a0603c91b227854abfa01c9e24143e39a1. Change-Id: Idcb40e6fd561b24e111afe7463f44c43c530fac5 --- M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c M tests/mgcp/mgcp_test.c 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 9ae82cd..bc9eca2 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -407,12 +407,12 @@ if (osmux_enable_conn(endp, conn_net, &addr->sin_addr, addr->sin_port) < 0 ) { LOGP(DLMGCP, LOGL_ERROR, - "Could not enable osmux in endpoint %d\n", + "Could not enable osmux in endpoint 0x%x\n", ENDPOINT_NUMBER(endp)); goto out; } - LOGP(DLMGCP, LOGL_INFO, "Enabling osmux in endpoint %d for %s:%u\n", + LOGP(DLMGCP, LOGL_INFO, "Enabling osmux in endpoint 0x%x for %s:%u\n", ENDPOINT_NUMBER(endp), inet_ntoa(addr->sin_addr), ntohs(addr->sin_port)); out: diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index bc191b5..e17bdae 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -691,7 +691,7 @@ if (!strcmp(token, "C")) endp->x_osmo_ign |= MGCP_X_OSMO_IGN_CALLID; else - LOGP(DLMGCP, LOGL_ERROR, "endpoint %x: received unknown X-Osmo-IGN item '%s'\n", + LOGP(DLMGCP, LOGL_ERROR, "endpoint 0x%x: received unknown X-Osmo-IGN item '%s'\n", ENDPOINT_NUMBER(endp), token); } diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c index 4cb16dd..a540056 100644 --- a/tests/mgcp/mgcp_test.c +++ b/tests/mgcp/mgcp_test.c @@ -550,7 +550,7 @@ static int mgcp_test_policy_cb(struct mgcp_trunk_config *cfg, int endpoint, int state, const char *transactio_id) { - fprintf(stderr, "Policy CB got state %d on endpoint %d\n", + fprintf(stderr, "Policy CB got state %d on endpoint 0x%x\n", state, endpoint); last_endpoint = endpoint; return MGCP_POLICY_CONT; @@ -813,7 +813,7 @@ OSMO_ASSERT(last_endpoint != -1); endp = &cfg->trunk.endpoints[last_endpoint]; - fprintf(stderr, "endpoint %d: " + fprintf(stderr, "endpoint 0x%x: " "payload type %d (expected %d)\n", last_endpoint, conn->end.codec->payload_type, t->ptype); -- To view, visit https://gerrit.osmocom.org/11375 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idcb40e6fd561b24e111afe7463f44c43c530fac5 Gerrit-Change-Number: 11375 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181016/e9b3939a/attachment.htm>