Change in docker-playground[master]: jenkins-common.sh: add docker_images_require()

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/11365 )

Change subject: jenkins-common.sh: add docker_images_require()
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11365/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11365/1//COMMIT_MSG@13
PS1, Line 13: Unless the NO_DOCKER_IMAGE_BUILD environment variable is specified,
> This documentation should go in the source tree, to not be lost to future readers in the commit hist […]
Done


https://gerrit.osmocom.org/#/c/11365/1//COMMIT_MSG@22
PS1, Line 22: on which a job depends. But it is not maintained anymore. And in that
> I added it and use it, it never was maintained by anyone besides me I guess, but "not maintained" is […]
How about: "nobody updates it when adding new docker images and some targets *don't build out of the box* with it" instead? :p

(Left it out in the next patch)


https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh
File jenkins-common.sh:

https://gerrit.osmocom.org/#/c/11365/1/jenkins-common.sh@5
PS1, Line 5: docker_images_require() {
> I don't see any callers of this function .. […]
In this commit, yes. But the next commit it will be used from all jenkins.sh files. Would it have been better to do both changes in one commit instead of two?



-- 
To view, visit https://gerrit.osmocom.org/11365
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0afdf3400282634fca9b31d57eaeedd6b5c28aa1
Gerrit-Change-Number: 11365
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Oct 2018 13:49:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181016/b350ea12/attachment.htm>