Change in docker-playground[master]: jenkins.sh: new IMAGE_SUFFIX environment variable

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Oct 16 11:36:35 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11366 )

Change subject: jenkins.sh: new IMAGE_SUFFIX environment variable
......................................................................


Patch Set 1:

(4 comments)

I see this is moving from make-style dependency tracking to naming each required image explicitly. It is also adding image rebuilding to the jenkins.sh directly. As you will notice in the comments, it's not so easy for me to let go of my current use pattern of 'make ttcn3-bsc-test' once, then invoke jenkins.sh as many times I like, but yeah. I think I can deal with it if any alternative would mean a lot of effort for the 'latest' tests ... ?

https://gerrit.osmocom.org/#/c/11366/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11366/1//COMMIT_MSG@7
PS1, Line 7: jenkins.sh: new IMAGE_SUFFIX environment variable
actually, the most profound change here is that you add calls to docker_images_require().


https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh
File m3ua-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@4
PS1, Line 4: [ -z "$IMAGE_SUFFIX" ] && IMAGE_SUFFIX="master"
I still prefer

  if [ -z xyz ]; then abc; fi

we are C hackers after all. Or if you want to be scripty, rather go for the if-unset shell pattern:

  FOO="${FOO:-bar}"


https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@6
PS1, Line 6: 	"debian-jessie-build" \
so it is not enough to issue the osmo-stp-foo image below, to also rebuild the images that it depends on? That was the idea of the top-level makefile: build that image *after* all of its dependencies, implicitly.


https://gerrit.osmocom.org/#/c/11366/1/m3ua-test/jenkins.sh@7
PS1, Line 7: 	"osmo-stp-$IMAGE_SUFFIX" \
with IMAGE_SUFFIX, I think of ".img". How about FEED_NAME



-- 
To view, visit https://gerrit.osmocom.org/11366
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbb708ab16cb71bab5069127945b63388222369e
Gerrit-Change-Number: 11366
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 16 Oct 2018 11:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181016/cebd3755/attachment.htm>


More information about the gerrit-log mailing list