Change in osmo-bsc[master]: lchan_fsm: notify conn of released lchan upon RF Release

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Oct 15 23:03:41 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11313 )

Change subject: lchan_fsm: notify conn of released lchan upon RF Release
......................................................................

lchan_fsm: notify conn of released lchan upon RF Release

Related: osmo-ttcn3-hacks If772dbbc5f9790d3f911465e1303dd0a99811154
Change-Id: I7621616c24588c2db15ad1ae7ca68cfa0fb76f66
---
M src/osmo-bsc/lchan_fsm.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c
index 9f2d6c3..39edaff 100644
--- a/src/osmo-bsc/lchan_fsm.c
+++ b/src/osmo-bsc/lchan_fsm.c
@@ -993,6 +993,13 @@
 {
 	int rc;
 	struct gsm_lchan *lchan = lchan_fi_lchan(fi);
+
+	/* For planned releases, a conn has already forgotten about the lchan. And later on, in
+	 * lchan_reset(), we make sure it does. But in case of releases from error handling, the
+	 * conn might as well notice now already that its lchan is becoming unusable. */
+	if (lchan->conn)
+		gscon_forget_lchan(lchan->conn, lchan);
+
 	rc = rsl_tx_rf_chan_release(lchan);
 	if (rc)
 		LOG_LCHAN(lchan, LOGL_ERROR, "Failed to Tx RSL RF Channel Release: rc=%d %s\n",

-- 
To view, visit https://gerrit.osmocom.org/11313
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7621616c24588c2db15ad1ae7ca68cfa0fb76f66
Gerrit-Change-Number: 11313
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181015/fb3bc421/attachment.htm>


More information about the gerrit-log mailing list