Change in osmo-remsim[master]: remsim: fix TPDU response size transmission

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Kévin Redon gerrit-no-reply at lists.osmocom.org
Mon Oct 15 18:03:10 UTC 2018


Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/11363


Change subject: remsim: fix TPDU response size transmission
......................................................................

remsim: fix TPDU response size transmission

the TDPU response data size can be up to 256.
this length cannot be stored in a uint8_t, which would cause the
length to become 0, no data being send, and the reader reset the
card because of misbehaviour of the card (i.e. no/malformed
response leading to the timeout of the waiting time).

Change-Id: Id38f9e597ffff242e89ea3dd9fbdf0c9f444cc03
---
M src/simtrace2-remsim_client.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/63/11363/1

diff --git a/src/simtrace2-remsim_client.c b/src/simtrace2-remsim_client.c
index f54ace3..365acb4 100644
--- a/src/simtrace2-remsim_client.c
+++ b/src/simtrace2-remsim_client.c
@@ -201,7 +201,7 @@
 
 /*! \brief Request the SIMtrace2 to transmit a Procedure Byte, then Tx */
 static int cardem_request_pb_and_tx(struct cardem_inst *ci, uint8_t pb,
-				    const uint8_t *data, uint8_t data_len_in)
+				    const uint8_t *data, uint16_t data_len_in)
 {
 	struct msgb *msg = st_msgb_alloc();
 	struct cardemu_usb_msg_tx_data *txd;

-- 
To view, visit https://gerrit.osmocom.org/11363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id38f9e597ffff242e89ea3dd9fbdf0c9f444cc03
Gerrit-Change-Number: 11363
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon <kredon at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181015/8480ffee/attachment.htm>


More information about the gerrit-log mailing list