This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11341 Change subject: hlr_ussd.c: fix: reject 'structured' SS requests ...................................................................... hlr_ussd.c: fix: reject 'structured' SS requests As we don't store any SS related information (e.g. call forwarding preferences) in the database, we don't handle 'structured' SS requests at all. Let's reject them by sending error message with FACILITY_NOT_SUPPORTED code. Change-Id: Ia1317c5d372a42473cce65c0c985103e43be77fd Related: OS#3651 --- M src/hlr_ussd.c 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/41/11341/1 diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c index c96f47c..ba373f3 100644 --- a/src/hlr_ussd.c +++ b/src/hlr_ussd.c @@ -399,8 +399,15 @@ LOGPSS(ss, LOGL_INFO, "SS CompType=%s, OpCode=%s\n", gsm0480_comp_type_name(comp_type), gsm0480_op_code_name(req->opcode)); - /* FIXME */ - return 0; + + /** + * FIXME: As we don't store any SS related information + * (e.g. call forwarding preferences) in the database, + * we don't handle "structured" SS requests at all. + */ + LOGPSS(ss, LOGL_NOTICE, "Structured SS requests are not supported, rejecting...\n"); + ss_tx_error(ss, req->invoke_id, GSM0480_ERR_CODE_FACILITY_NOT_SUPPORTED); + return -ENOTSUP; } /* Handle a USSD GSUP message for a given SS Session received from VLR or EUSE */ -- To view, visit https://gerrit.osmocom.org/11341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1317c5d372a42473cce65c0c985103e43be77fd Gerrit-Change-Number: 11341 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181012/dc3dcd84/attachment.htm>