Change in osmo-pcu[master]: fix width of mobile identity length in paging request [WIP]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri Oct 12 14:12:56 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11330


Change subject: fix width of mobile identity length in paging request [WIP]
......................................................................

fix width of mobile identity length in paging request [WIP]

Do not merge! This change is probably wrong.
Only a WIP PCU test of mine relies on this.

Change-Id: If5f6e79ada1df6d30d4f10bf6c93284ad1bf10ea
---
M src/encoding.cpp
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/11330/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index 1f96458..50ba9ac 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -623,8 +623,7 @@
 	bitvec_write_field(dest, &wp,0x0,4);  // Channel Needed
 
 	// Mobile Identity
-	bitvec_write_field(dest, &wp,ptmsi_len+1,8);  // Mobile Identity length
-	bitvec_write_field(dest, &wp,0xf,4);          // unused
+	bitvec_write_field(dest, &wp,ptmsi_len+1,4);  // Mobile Identity length
 	bitvec_write_field(dest, &wp,0x4,4);          // PTMSI type
 	for (int i = 0; i < ptmsi_len; i++)
 	{

-- 
To view, visit https://gerrit.osmocom.org/11330
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5f6e79ada1df6d30d4f10bf6c93284ad1bf10ea
Gerrit-Change-Number: 11330
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181012/a7d83205/attachment.htm>


More information about the gerrit-log mailing list