This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11144 ) Change subject: support osmo-sip-connector with kamailio ...................................................................... Patch Set 6: Code-Review+1 (2 comments) good except for the root fs / sudo things https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh File net/tmpl_std/run.sh: https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh@79 PS6, Line 79: kamailio="$(sudo which kamailio)" oof, ok ... maybe instead we should include /sbin or something in the $PATH? $(PATH="$PATH:/usr/sbin;/sbin" which kamailio) https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh@88 PS6, Line 88: sudo mkdir -p /var/run/kamailio can we instead keep the kamailio run dir as a local subdir? Is it not configurable in kamailio.cfg? Above sudo is intended only for configuring the network, all the remaining stuff should be userland and shouldn't modify the current root system. Hmm, I think we should even remove sudo from the tcpdumps, possibly skip tcpdump if the user has no setuid on dumpcap; and maybe even separate all network config sudo stuff to a separate script... (what was I thinking!) -- To view, visit https://gerrit.osmocom.org/11144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2 Gerrit-Change-Number: 11144 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-CC: daniel <dwillmann at sysmocom.de> Gerrit-Comment-Date: Fri, 12 Oct 2018 11:06:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181012/4da8d4d2/attachment.htm>