Change in osmo-bsc[master]: vty 'show bts'/'show trx': display IPs and ports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 11 12:40:24 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11290 )

Change subject: vty 'show bts'/'show trx': display IPs and ports
......................................................................


Patch Set 3: Verified+1

(3 comments)

still needs the space,const,commit-tag fixed...

https://gerrit.osmocom.org/#/c/11290/3//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11290/3//COMMIT_MSG@25
PS3, Line 25: Relates: OS#3145
should be "Related:"


https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@293
PS3, Line 293: /*! Dump the IP addresses and ports of the input signal link's timeslot.
> I missed the fact that osmo_sock_get_name doesn't return a static buffer [like most parts of osmocom […]
wow, the API doc totally omits that fact.


https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@1065
PS3, Line 1065: 		vty_out(vty, "  ip.access stream ID: 0x%02x ", trx->rsl_tei);
(I like above "OML Link", maybe we can also say "RSL Link" here ... but since you're just editing existing code, maybe nevermind instead)



-- 
To view, visit https://gerrit.osmocom.org/11290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37f020fcdb68cafcdbdb621808483d1dd996354f
Gerrit-Change-Number: 11290
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Oct 2018 12:40:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181011/5c152d1c/attachment.htm>


More information about the gerrit-log mailing list