Change in osmo-dev[master]: exit if xterm was not found

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Oct 11 12:28:29 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11143 )

Change subject: exit if xterm was not found
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/11143/4/net/tmpl_std/run.sh
File net/tmpl_std/run.sh:

https://gerrit.osmocom.org/#/c/11143/4/net/tmpl_std/run.sh@45
PS4, Line 45:     exit 1
> no, wait, we invoke term() only after starting the tcpdumps, so we should check terminal presence ou […]
(which also makes sense apart from the exit: no need to do 'which' for each term() invocation, once up front is plenty)



-- 
To view, visit https://gerrit.osmocom.org/11143
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie823e17ff1e7ad3ba23998233b41a810c90858b3
Gerrit-Change-Number: 11143
Gerrit-PatchSet: 4
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Assignee: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Oct 2018 12:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181011/8f7a69e0/attachment.htm>


More information about the gerrit-log mailing list