Change in libosmocore[master]: gsm_08_58.h: Introduce struct abis_rsl_link_id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Oct 10 17:47:28 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11302 )

Change subject: gsm_08_58.h: Introduce struct abis_rsl_link_id
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/11302/1/include/osmocom/gsm/protocol/gsm_08_58.h
File include/osmocom/gsm/protocol/gsm_08_58.h:

https://gerrit.osmocom.org/#/c/11302/1/include/osmocom/gsm/protocol/gsm_08_58.h@35
PS1, Line 35: struct abis_rsl_link_id {
> Perhaps a union is better here? […]
yes, a struct with a single union member looks a bit odd. but I don't really care too much...



-- 
To view, visit https://gerrit.osmocom.org/11302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75a493bcfdf46c028ea466867d0c0d83d46343
Gerrit-Change-Number: 11302
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Oct 2018 17:47:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181010/51683c54/attachment.htm>


More information about the gerrit-log mailing list