Change in osmo-ttcn3-hacks[master]: resolve ambiguity of MobileIdentityLV type name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Wed Oct 10 13:34:20 UTC 2018


Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/11292 )

Change subject: resolve ambiguity of MobileIdentityLV type name
......................................................................

resolve ambiguity of MobileIdentityLV type name

There are two distinct types defined for a Mobile Identity LV IE.

One type definition lives in GSM_RR_Types and defines the "canonical"
IE form, with a full octet for the length.

Another one lives in RLCMAC_CSN1_Types which defines how a mobile
identity appears in paging requests. In this case, the length field
is only 4 bits in size. Rename this latter type from MobileIdentityLV to
MobileIdentityLV_Paging and add a comment to highlight this distinction.
TS 144 060 Table 11.2.10.2 explicitly states that only the value
part of this IE matches the definition of the canonical IE as
"defined in 3GPP TS 44.018" (actually, TS 44.018 further redirects
the reader to TS 124 008; see section 10.5.1.4 there).

As an aside, a third definition of the MobileIdentityLV type exists
in MobileL3_CommonIE_Types, which matches the "canonical" form.

Change-Id: I990316cd5ef5aaf079b03c344e3185ae6ab8ba6d
Related: OS#2404
---
M library/GSM_RR_Types.ttcn
M library/RLCMAC_CSN1_Types.ttcn
2 files changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 675271f..26783f9 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -231,6 +231,7 @@
 		 variant "FIELDORDER(lsb)"
 	};
 
+	/* TS 24.008 10.5.1.4 "Mobile Identity" */
 	type record MobileIdentityLV {
 		uint8_t		len,
 		MobileIdentity	mi
diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn
index fbd01d4..9a7c867 100644
--- a/library/RLCMAC_CSN1_Types.ttcn
+++ b/library/RLCMAC_CSN1_Types.ttcn
@@ -185,7 +185,11 @@
 	};
 
 	/* 11.2.10 Packet Paging Request */
-	type record MobileIdentityLV {
+	type record MobileIdentityLV_Paging {
+		/* Note that the size of 'len' differs from that of the Mobile Identify IE
+		 * as defined in 3GPP TS 24.008 10.5.1.4 "Mobile Identity"; Paging Requests
+		 * use only 4 bit to encode the length of a mobile identity, whereas the IE
+		 * uses a byte. */
 		uint4_t			len,
 		octetstring		mobile_id
 	} with { variant (len) "LENGTHTO(mobile_id)" };
@@ -193,7 +197,7 @@
 		BIT1			presence ('0'B),
 		BIT1			ptmsi_or_mobile_id,
 		GsmTmsi			ptmsi optional,
-		MobileIdentityLV	mobile_identity optional
+		MobileIdentityLV_Paging	mobile_identity optional
 	} with {
 		variant (ptmsi) "PRESENCE(ptmsi_or_mobile_id = '0'B)"
 		variant (mobile_identity) "PRESENCE(ptmsi_or_mobile_id = '1'B)"
@@ -202,7 +206,7 @@
 		BIT1			presence ('1'B),
 		BIT1			tmsi_or_mobile_id,
 		GsmTmsi			tmsi optional,
-		MobileIdentityLV	mobile_identity optional,
+		MobileIdentityLV_Paging	mobile_identity optional,
 		ChannelNeeded		chan_needed,
 		BIT1			emlpp_prio_present,
 		uint3_t			emlpp_prio optional

-- 
To view, visit https://gerrit.osmocom.org/11292
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I990316cd5ef5aaf079b03c344e3185ae6ab8ba6d
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181010/661f31f2/attachment.htm>


More information about the gerrit-log mailing list