Change in osmo-bsc[master]: vty 'show bts'/'show trx': display IPs and ports

[Harald Welte]

Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11290 )

Change subject: vty 'show bts'/'show trx': display IPs and ports
......................................................................


Patch Set 3:

(3 comments)

In terms of layering, the e1inp_sign_link_name() function should becom part of libosmo-abis.  This way it's generic and can be used by whatever application to get a string representation of whatever signaling link.

https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@293
PS3, Line 293: /*! Dump the IP addresses and ports of the input signal link's timeslot.
in therm of API design, I don't think it makes sense to have a separate 'dump' function here, particularly not one that includes the newline at the end.

I suggest to have a function like e1inp_sign_link_name(const struct e1inp_sign_link *e1l) which will simply return an empty string or "<none>" if the e1l is NULL.  This can then be used from a printf / vty_out() statement.


https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@296
PS3, Line 296: static void e1isl_dump_vty_tcp(struct vty *vty, struct e1inp_sign_link *e1l)
this argument is read-only, so it should be 'const struct e1inp_sign_link *'


https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@298
PS3, Line 298: 	if(e1l) {
if is not a function, hence we use a space.



-- 
To view, visit https://gerrit.osmocom.org/11290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37f020fcdb68cafcdbdb621808483d1dd996354f
Gerrit-Change-Number: 11290
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 10 Oct 2018 10:12:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181010/0722777d/attachment.htm>