Change in osmo-ttcn3-hacks[master]: resolve ambiguity of MobileIdentityLV type name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Wed Oct 10 10:06:33 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11292 )

Change subject: resolve ambiguity of MobileIdentityLV type name
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
> 
> fine with me.  However, as you may know, types can always be prefixed by the Module name, so you can have something like GSM_RR_Types.MobileIdentityLV to distinguish it from other types in other modules.

That also occurred to me. But I think in this case the difference is too subtle to be easily noticed. I suppose the generated encoders/decoders will always use the correct type, but I worry that readers of the code will easily miss the difference.


-- 
To view, visit https://gerrit.osmocom.org/11292
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I990316cd5ef5aaf079b03c344e3185ae6ab8ba6d
Gerrit-Change-Number: 11292
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Oct 2018 10:06:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181010/96afa7b2/attachment.htm>


More information about the gerrit-log mailing list