Change in osmo-bsc[master]: vty 'show bts'/'show trx': display IPs and ports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Oct 9 14:05:03 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11290 )

Change subject: vty 'show bts'/'show trx': display IPs and ports
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11290/1/src/osmo-bsc/bsc_vty.c
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/#/c/11290/1/src/osmo-bsc/bsc_vty.c@301
PS1, Line 301: e1l->ts->driver.ipaccess.fd.fd
I'm wondering if this is a protocol layer violation, because it's directly accessing structs from e1 here. However, e1isl_dump_vty() (directly above) is doing something similar. So I guess it is fine?



-- 
To view, visit https://gerrit.osmocom.org/11290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37f020fcdb68cafcdbdb621808483d1dd996354f
Gerrit-Change-Number: 11290
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Oct 2018 14:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181009/1fd2f306/attachment.htm>


More information about the gerrit-log mailing list