Change in osmocom-bb[master]: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sun Oct 7 15:26:45 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11254 )

Change subject: layer23/l23sap.c: use safe wrapper around rsl_dec_chan_nr()
......................................................................


Patch Set 1:

> one coudl simply put an OSMO_ASSERT() in the code. [...]
> I mean, if this condition is hit, it for sure is a serious
> bug in the program that should be fixed

I don't consider this as a bug, since there are Osmocom
specific cbits (e.g. CBCH and PDCH), and rsl_dec_chan_nr()
is not able to decode such "out of the specs." chan_nr values.

Crashing the whole L23 application just because an unknown
(yet) kind of L2 frame is received doesn't look like
a good idea for me...


-- 
To view, visit https://gerrit.osmocom.org/11254
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id78304f494be70aa05e2da11c785ba5d9aeaf6db
Gerrit-Change-Number: 11254
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Sun, 07 Oct 2018 15:26:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181007/997fdb56/attachment.htm>


More information about the gerrit-log mailing list